gromero commented on PR #12189: URL: https://github.com/apache/tvm/pull/12189#issuecomment-1198670353
@guberti No worries! I think that there are still some blindspots in the review flow that needs to be discussed by the TVM community and maybe be materialized into docs to avoid confusion, and that's is an example of it in my view, so really I just would like to raise the issue here. I don't even know how you (or anybody else) would have made sure all the original reviewers would have signed off again. Pretty sure you could have posted a message tagging us, but what if it was a new contributor less familiarized with the process (not a reviewer nor a committer) that was submitting the additional changes? I think that's an issue which must be addressed on the reviewer / committer / maintainer side, after a proper discussion and consensus of course. The contributor / author can't act as an "arbitrator" here :) That issue is also related somehow to this section https://github.com/apache/tvm/blame/main/docs/contribute/code_review.rst#L52 about given sometime for other reviewers to review a change. Obviously that change is small, not an architectural, but I wonder if we should wait at least 24h for a change not trivial (a typo fix would be a trivial change) to be merged. Of course the case here is even more special because @mehrdadh merged it and he was indeed one of the initial reviewers. That's another blindspot in the review flow, I think. I have to say that I really went for checking the PR for merging the next day just to see it already merged with the additional commits, without I having the change to request, for instance, a split into another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
