MuhammadTahaNaveed commented on PR #465: URL: https://github.com/apache/age/pull/465#issuecomment-1372628842
> @MuhammadTahaNaveed Yeah, that is a bit misleading. The clang file has not really been updated in a while and might be missing a few coding rules. Okay, then I will cross check the rules in clang-format with the guidelines written in documentation and add rules if some are missing. > Additionally, we need to think about how we will roll this out. There is the possibility that many files may already have some minor violations due to changes in the coding styles or just minor overlooked cases. Yes, I thought about this before submitting the PR. The way I implemented the workflow makes sure that validation checks only run on the files touched/modified or created by the contributor. However this may also introduce some warnings on the legacy code that was not following the rules in those specific files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
