MuhammadTahaNaveed commented on PR #465:
URL: https://github.com/apache/age/pull/465#issuecomment-1379942584

   @jrgemignani I have cross checked the rules defined in .clang-format with 
the ones defined in documentation. Most of the rules are current with 
documentation. However I had some confusions.
   
   - Documentation says to indent case labels in switch-case blocks (refer 
img), but in clang-format, it is set to false `IndentCaseLabels: false`
   
![image](https://user-images.githubusercontent.com/85064039/212005265-32efc278-f7d7-4bee-8f01-efb7fb9caf6d.png)
   I have seen in code as well that case labels are not idented.
   - Documentation says `If all the bodies of if/else statement contain a 
single line, omit braces.` but I don't think their is any style option listed 
in [clang style options 
documentation](https://clang.llvm.org/docs/ClangFormatStyleOptions.html) to 
ensure this (as far as I have seen).
   
   Other then that, .clang-fromat looks good to me.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to