jrgemignani commented on PR #905: URL: https://github.com/apache/age/pull/905#issuecomment-1542586056
@Zainab-Saad Btw, for future reference, you don't need this much detail for your extended commit description - ``` commit 87f860151fc17f7d124ddf3f409f2b24acd928de Author: Zainab Saad <[email protected]> Date: Wed May 10 22:33:42 2023 +0500 Typecast bool to integer and vice versa (#905) * Typecast boolean to integer - Modify agtype_typecast_int and agtype_to_int4 in agtype.c * Add regression tests for typecast boolean to integer - Add regression tests: sql script, expected results in agtype.sql, agtype.out - Add regression tests: sql script, expected results in expr.sql, expr.out * Typecast integer to boolean - Modify transform_cypher_typecast in cypher_expr.c - Modify agtype_to_bool in agtype.c * Add regression tests for typecast integer to boolean - Add/Modify regression tests in agtype.sql, agtype.out - Add/Modify regression tests in expr.sql, expr.out * Add regression tests for edge cases - Add regression tests in expr.sql, expr.out - These regression tests check the edge cases for typecasting * Add regression tests for edge cases - II - Add regression tests in agtype.sql, agtype.out - Add edge cases for agtype_to_int4 * Fix & Add regression tests - Fix comments in agtype.sql, agtype.out - Add regression test for edge case ``` Something like this would be more concise - ``` commit 87f860151fc17f7d124ddf3f409f2b24acd928de Author: Zainab Saad <[email protected]> Date: Wed May 10 22:33:42 2023 +0500 Typecast bool to integer and vice versa (#905) * Typecast boolean to integer - Modify agtype_typecast_int and agtype_to_int4 * Typecast integer to boolean - Modify transform_cypher_typecast - Modify agtype_to_bool - Add regression tests ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
