Zainab-Saad commented on PR #905: URL: https://github.com/apache/age/pull/905#issuecomment-1545953548
@dehowef I have seen that a possible fix of this issue (eliminating int to bool implicit casting while retaining the explicit :: casting) is to define a new function `agtype_typecast_bool` which will be used for ::boolean casting while inside the `agtype_to_bool`, we simply remove the casting from int to bool. Moreover, I am looking into edge cases where implicit casting from bool to int/int8 can cause issues (did not find an edge case yet). The code base initially did not have `agtype_typecast_bool` defined (there is this function for other data types like `agtype_typecast_int`, `agtype_typecast_numeric` etc.) and I was wondering if there was a specific reason for this exclusion that I should be aware of. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
