jrgemignani commented on code in PR #1018:
URL: https://github.com/apache/age/pull/1018#discussion_r1260193934
##########
src/backend/executor/cypher_merge.c:
##########
@@ -57,33 +57,28 @@ const CustomExecMethods cypher_merge_exec_methods =
{MERGE_SCAN_STATE_NAME,
exec_cypher_merge,
end_cypher_merge,
rescan_cypher_merge,
- NULL,
- NULL,
- NULL,
- NULL,
- NULL,
- NULL,
- NULL,
- NULL};
+ NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL};
/*
- * Initializes the MERGE Execution Node at the begginning of the execution
+ * Initializes the MERGE Execution Node at the beginning of the execution
* phase.
*/
static void begin_cypher_merge(CustomScanState *node, EState *estate,
int eflags)
{
cypher_merge_custom_scan_state *css =
(cypher_merge_custom_scan_state *)node;
- ListCell *lc;
- Plan *subplan;
+ ListCell *lc = NULL;
+ Plan *subplan = NULL;
Assert(list_length(css->cs->custom_plans) == 1);
// initialize the subplan
subplan = linitial(css->cs->custom_plans);
node->ss.ps.lefttree = ExecInitNode(subplan, estate, eflags);
+ /* TODO is this necessary? Removing it seems to not have an impact */
Review Comment:
That is something that **needs** to be looked into. So, it is something
pending. Could be for an intern?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
