MuhammadTahaNaveed commented on code in PR #1018:
URL: https://github.com/apache/age/pull/1018#discussion_r1260592392
##########
META.json:
##########
@@ -23,7 +23,7 @@
}
},
"resources": {
- "homepage": "https://github.com/apache/age/tree/AGE_PG12.1.0_ALPHA";,
+ "homepage": "https://github.com/apache/age/tree/master";,
"bugtracker": {
Review Comment:
shouldn't it point to PG12 branch ?
##########
age--1.0.0--1.1.0.sql:
##########
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
is there 1.0.0 version for PG12 ? Should this update file be added ?
##########
age--1.3.0.sql:
##########
@@ -4194,8 +4213,8 @@ CALLED ON NULL INPUT
PARALLEL SAFE
AS 'MODULE_PATHNAME';
-CREATE FUNCTION ag_catalog.age_create_barbell_graph(graph_name name,
- graph_size int,
+CREATE FUNCTION ag_catalog.age_create_barbell_graph(graph_name name,
+ graph_size int,
Review Comment:
[formatting]
##########
drivers/golang/age/mapper.go:
##########
@@ -23,7 +23,7 @@ import (
"reflect"
"strings"
Review Comment:
[formatting] extra line
##########
src/backend/parser/cypher_analyze.c:
##########
@@ -72,9 +72,10 @@ static Query *analyze_cypher(List *stmt, ParseState
*parent_pstate,
static Query *analyze_cypher_and_coerce(List *stmt, RangeTblFunction *rtfunc,
ParseState *parent_pstate,
const char *query_str, int query_loc,
- char *graph_name, uint32 graph_oid,
+ char *graph_name, Oid graph_oid,
Review Comment:
is this change valid? didnt we shift to uint32 in PG12?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
