jrgemignani commented on PR #2286:
URL: https://github.com/apache/age/pull/2286#issuecomment-3715938341
@jpabbuehl @tdrz
> This change is backward compatible:
>
> 64-bit systems continue using pass-by-value
> 32-bit systems now work with pass-by-reference
Unfortunately, this PR breaks nearly all of the regression tests, so it
isn't backward compatible. I would strongly suggest to anyone that before a PR
is submitted, `make installcheck` is run locally to verify all regression
tests. Keep in mind that all of our regression tests run under standard
PostgreSQL.
No PR can be accepted until it can pass all regression tests.
```
Run make PG_CONFIG=$HOME/pg17/bin/pg_config installcheck
EXTRA_TESTS="pgvector fuzzystrmatch pg_trgm"
echo "# +++ regress install-check in +++" &&
/home/runner/pg17/lib/postgresql/pgxs/src/makefiles/../../src/test/regress/pg_regress
--inputdir=./ --bindir='/home/runner/pg17/bin' --load-extension=age
--inputdir=.//regress --outputdir=.//regress
--temp-instance=.//regress/instance --port=61958 --encoding=UTF-8 --temp-config
.//regress/age_regression.conf --dbname=contrib_regression scan graphid agtype
agtype_hash_cmp catalog cypher expr cypher_create cypher_match cypher_unwind
cypher_set cypher_remove cypher_delete cypher_with cypher_vle cypher_union
cypher_call cypher_merge cypher_subquery age_global_graph age_load index
analyze graph_generation name_validation jsonb_operators list_comprehension
map_projection pgvector fuzzystrmatch pg_trgm drop
# +++ regress install-check in +++
# initializing database system by running initdb
# using temp instance on port 61958 with PID 2978
ok 1 - scan 309 ms
not ok 2 - graphid 423 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 3 - agtype 28 ms
ok 4 - agtype_hash_cmp 19 ms
not ok 5 - catalog 409 ms
# (test process exited with exit code 2)
not ok 6 - cypher 32 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 7 - expr 2 ms
not ok 8 - cypher_create 425 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 9 - cypher_match 33 ms
not ok 10 - cypher_unwind 428 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 11 - cypher_set 27 ms
# (test process exited with exit code 2)
not ok 12 - cypher_remove 3 ms
not ok 13 - cypher_delete 428 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 14 - cypher_with 27 ms
# (test process exited with exit code 2)
not ok 15 - cypher_vle 3 ms
not ok 16 - cypher_union 458 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 17 - cypher_call 28 ms
not ok 18 - cypher_merge 461 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 19 - cypher_subquery 25 ms
# (test process exited with exit code 2)
not ok 20 - age_global_graph 3 ms
# (test process exited with exit code 2)
not ok 21 - age_load 438 ms
not ok 22 - index 28 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 23 - analyze 3 ms
# (test process exited with exit code 2)
not ok 24 - graph_generation 447 ms
# (test process exited with exit code 2)
not ok 25 - name_validation 32 ms
# (test process exited with exit code 2)
not ok 26 - jsonb_operators 3 ms
# (test process exited with exit code 2)
not ok 27 - list_comprehension 422 ms
# (test process exited with exit code 2)
not ok 28 - map_projection 27 ms
# (test process exited with exit code 2)
not ok 29 - pgvector 3 ms
# (test process exited with exit code 2)
not ok 30 - fuzzystrmatch 439 ms
not ok 31 - pg_trgm 27 ms
# (test process exited with exit code 2)
# (test process exited with exit code 2)
not ok 32 - drop 4 ms
# 30 of 32 tests failed.
1..32
# The differences that caused some tests to fail can be viewed in the file
"/home/runner/work/age/age/regress/regression.diffs".
# A copy of the test summary that you see above is saved in the file
"/home/runner/work/age/age/regress/regression.out".
make: *** [/home/runner/pg17/lib/postgresql/pgxs/src/makefiles/pgxs.mk:436:
installcheck] Error 1
Error: Process completed with exit code 2.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
