jpabbuehl commented on PR #2286: URL: https://github.com/apache/age/pull/2286#issuecomment-3734929048
@jrgemignani Thanks for your feedback. Indeed the PR description needs to be adjusted.I pivoted to a more targeted Makefile-only approach instead of modifying graphid.h Good idea on the explicit parameter approach - I've removed the auto-detection logic. Now SIZEOF_DATUM must be explicitly passed (e.g., make SIZEOF_DATUM=4) for 32-bit builds. When unspecified, normal 64-bit behavior goes on. On the sed replacement from Copilot's feedback - I've simplified to an exact pattern match (^ PASSEDBYVALUE,$) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
