MuhammadTahaNaveed commented on PR #2303: URL: https://github.com/apache/age/pull/2303#issuecomment-4594559382
@jrgemignani > 1. **`_get_vertex_by_graphid` has no `REVOKE … FROM PUBLIC`.** Largely mitigated because the underlying `get_vertex` performs `pg_class_aclcheck(… ACL_SELECT)`, so a caller lacking SELECT on the label table errors out. It still bypasses RLS row policies, though AGE label tables don't use RLS. Adding the REVOKE would be defense-in-depth. > 2. **OID-dependent error text**: `reverse() unsupported argument type 16843` embeds the dynamic `VERTEXOID`. Deterministic in a fresh regress DB, but brittle if catalog OIDs shift. Addressed both. > The one structurally risky element — the edge composite field order (id, label, end_id, start_id, properties), with end_id before start_id `end_id` precedes `start_id` intentionally, it matches the agtype edge's canonical key order (keys sorted by length, `end_id=6 < start_id=8`), keeping the composite positionally consistent with the agtype representation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
