crprashant commented on code in PR #2417: URL: https://github.com/apache/age/pull/2417#discussion_r3376521263
########## age--1.7.0--y.y.y.sql: ########## @@ -464,6 +464,1841 @@ $$; -- agtype <-> jsonb bidirectional casts -- +-- agtype -> jsonb (explicit) +-- Uses json intermediate (agtype_to_json -> json::jsonb) because agtype +-- extends jsonb's binary format with types (AGTV_INTEGER, AGTV_FLOAT, +-- AGTV_VERTEX, AGTV_EDGE, AGTV_PATH) that jsonb does not recognize. +CREATE FUNCTION ag_catalog.agtype_to_jsonb(agtype) + RETURNS jsonb + LANGUAGE sql + IMMUTABLE +RETURNS NULL ON NULL INPUT +PARALLEL SAFE +AS 'SELECT ag_catalog.agtype_to_json(-- Review Comment: Good catch — the upgrade template got garbled during the rebase conflict resolution (an automated merge mangled this file, inlining the agtype<->jsonb cast section inside the agtype_to_jsonb function's string literal so the quote never closed). Fixed in the latest push: I restored the pristine master version of age--1.7.0--y.y.y.sql and cleanly appended only the 10 ALTER OPERATOR ... SET (RESTRICT, JOIN) statements. The agtype_to_jsonb definition is back to a normal one-liner and the file diff vs master is now exactly the 34-line selectivity block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
