crprashant commented on PR #2417: URL: https://github.com/apache/age/pull/2417#issuecomment-4653795449
Pushed a fix addressing the latest review. During the rebase, an automated merge garbled `age--1.7.0--y.y.y.sql` (it inlined the new `agtype<->jsonb` cast section *inside* the `agtype_to_jsonb` function's string literal, leaving an unclosed quote) and left a double backslash in the `Makefile` REGRESS continuation. **Fixes in the latest push (`f090a094`):** - `Makefile`: restored a single trailing backslash so `agtype_jsonb_cast` and `containment_selectivity` chain correctly. Resolves the `missing separator` build failure. - `age--1.7.0--y.y.y.sql`: regenerated from the pristine master version with only the 10 `ALTER OPERATOR ... SET (RESTRICT, JOIN)` statements appended. The `agtype_to_jsonb` definition is back to a clean one-liner and the file's diff vs master is now exactly the 34-line selectivity block — no unclosed quotes or stray fragments. All three earlier review items (deterministic `ORDER BY` in `cypher_match.sql`/`cypher_vle.sql` and the scoped `matchingsel` guard) are preserved through the rebase. The PR is current with master and ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
