Copilot commented on code in PR #2445:
URL: https://github.com/apache/age/pull/2445#discussion_r3456185485
##########
.github/workflows/installcheck.yaml:
##########
@@ -28,6 +33,22 @@ jobs:
sudo apt-get update
sudo apt-get install -y build-essential libreadline-dev zlib1g-dev
flex bison
+ - name: Verify Bison version (grammar conflict counts are pinned)
+ run: |
+ ver=$(bison --version | head -1 | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
+ echo "bison $ver"
+ case "$ver" in
Review Comment:
The version parsing is a bit brittle: if `bison --version` output format
changes or the regex doesn’t match, `ver` becomes empty and the guard fails
with a confusing `Bison != 3.8.x` message. Using a simpler parser (awk) and
explicitly erroring on an empty version makes the step more robust and
actionable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
