Copilot commented on code in PR #2445: URL: https://github.com/apache/age/pull/2445#discussion_r3493213254
########## .github/workflows/installcheck.yaml: ########## @@ -9,7 +9,12 @@ on: jobs: build: - runs-on: ubuntu-latest + # Pinned (not ubuntu-latest) so the Bison version stays fixed at 3.8.x. + # The Cypher GLR grammar pins exact conflict counts via %expect / %expect-rr + # in src/backend/parser/cypher_gram.y, and Bison treats %expect as exact-match: + # a different Bison version can report different counts and break the build. + # Freezing the runner image freezes Bison; bump both together, intentionally. + runs-on: ubuntu-24.04 Review Comment: PR description says `runs-on: ubuntu-latest` → `ubuntu-24.04`, but only this workflow has been pinned; other workflows in `.github/workflows/` still use `ubuntu-latest` (jdbc-driver.yaml, nodejs-driver.yaml, go-driver.yml, python-driver.yaml). Either pin those too, or narrow the PR description/title to specify it only applies to Build / Regression so expectations match the actual changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
