gregfelice commented on PR #2455: URL: https://github.com/apache/age/pull/2455#issuecomment-4875229597
Release mechanics look good — version bumps (`age.control`, `META.json`, `README`, `Dockerfile`), the `RELEASE` changelog, and the rename of `age--1.7.0--y.y.y.sql` → `age--1.7.0--1.8.0.sql` are all correct, and CI is green. One nit on the newly-added **next-version** template, `age--1.8.0--y.y.y.sql`: it carries a stray leading block (a concrete `'1.8.0'` echo + `\quit`) prepended above the real `'1.X.0'` template: ```sql -- complain if script is sourced in psql, rather than via CREATE EXTENSION \echo Use "ALTER EXTENSION age UPDATE TO '1.8.0'" to load this file. \quit <-- stray --* This is a TEMPLATE for upgrading from the previous version of Apache AGE ... \echo Use "ALTER EXTENSION age UPDATE TO '1.X.0'" to load this file. \quit ``` No impact on the 1.8.0 release itself (a `y.y.y` script is never resolved/sourced). But it's a latent footgun for the *next* cycle: when this file is renamed to `age--1.8.0--1.9.0.sql` and changes are appended, that orphan `\quit` sits above everything and isn't a `--*` line, so the "REMOVE ALL LINES ABOVE ... that start with --*" instruction won't catch it — the resulting upgrade script would `\quit` before applying any changes. Fix is just dropping those 6 lines so the file starts with the `--* This is a TEMPLATE ...` block, matching the canonical template form. Happy to push it to the branch if that's easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
