gregfelice commented on PR #2458: URL: https://github.com/apache/age/pull/2458#issuecomment-4875544656
@jrgemignani ready for review when you have a cycle. This fixes the #2450 segfault where a `GENERATED ALWAYS ... STORED` (or any extra) column on a label table crashed the backend on CREATE/MERGE/SET — root cause and the two-part fix (null-init the entity slot + `ExecComputeStoredGenerated`) are in the description. New `generated_columns` regression test covers vertex + edge across all three write paths, and CI is green. One design note called out in the PR: on SET, AGE rebuilds the row from `id`/`properties`, so a *generated* column recomputes correctly but a *plain* column resets to NULL — I scoped plain-column preservation out. Happy to adjust if you'd rather handle that here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
