MuhammadTahaNaveed commented on PR #2458:
URL: https://github.com/apache/age/pull/2458#issuecomment-4875747849
@gregfelice
**GPT 5.5 xhigh review:**
**Findings**
1. **[P1] Stored generated columns using `tableoid` are computed
incorrectly**
- `src/backend/executor/cypher_utils.c:354`
- `src/backend/executor/cypher_set.c:143`
The new `ExecComputeStoredGenerated(...)` calls compute stored
generated columns, but the tuple slot does not appear to have `tts_tableOid`
set first. PostgreSQL’s own executor sets
`slot->tts_tableOid = RelationGetRelid(...)` before computing stored
generated columns.
Repro: adding this to a vertex label produces `InvalidOid` instead of
the label table OID:
```sql
ALTER TABLE tableoid_case."T"
ADD COLUMN tbl oid GENERATED ALWAYS AS (tableoid) STORED;
Then CREATE and SET through Cypher both leave tbl as - / invalid. The fix
should set elemTupleSlot->tts_tableOid before ExecComputeStoredGenerated(...)
in both insert/create and update/set
paths, and add a regression case for tableoid.
2. **[P1] PROJECT.yaml adds incorrect Apache project metadata**
- PROJECT.yaml:16 says license: Proprietary
- PROJECT.yaml:22 says owner: Rizlabs
- PROJECT.yaml:25 points at a Rizlabs repo
**This file is completely unrelated to the fix and should be removed
immediately.**
3. **[P2] Branch needs a rebase onto current master**
The PR is based on merge base 12e2a31c, while current apache/master is
d84b4578. It is missing several upstream commits, so the branch-local
regression suite is stale. Please rebase so
CI runs against the current tree.
4. **[P3] git diff --check fails on trailing whitespace**
The new regress/expected/generated_columns.out has multiple
trailing-whitespace lines and a blank line at EOF. Please clean that up so
whitespace checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
