potiuk commented on issue #4483: [AIRFLOW-3673] Add official dockerfile
URL: https://github.com/apache/airflow/pull/4483#issuecomment-454394545
 
 
   Ah. That's nice. 
   
   What do you think @Fokko about bringing the airflow-ci Dockerfile to the 
main airflow project? I think it makes sense to be in airflow repo rather than 
in the separate project? 
   
   Now that we have Dockerhub enabled it will be just a matter of bringing it 
in and defining separate a dockerfile lockation as described in 
https://github.com/apache/airflow-ci/pull/4 . It already was discussed (I made 
comment about it) in 
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-7+Simplified+development+workflow
 and it seems that being able to change the Dockerfiles together with the code 
you are working on in your fork would be a nice thing. 
   
   Then anyone could setup their own DockerHub + Travis CI account and modify 
the CI scripts to use their image rather than the apache ones. I would also 
like to use the same approach (I am already doing it in our fork) to be able to 
run system tests for GCP using similar approach with Cloud Build (which is much 
better integrated for GCP system tests) - as described in  
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-4+Support+for+System+Tests+for+external+systems
 
   
   I just finished a big piece of work and over the next couple of days and can 
make some PR(s) with that to bring modularisation in and to add Travis CI + 
possibly later Cloud Build images to the 'airflow' repo.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to