potiuk commented on issue #4483: [AIRFLOW-3673] Add official dockerfile
URL: https://github.com/apache/airflow/pull/4483#issuecomment-453624798
 
 
   Actually - I looked again at the final Dockerfile and I have to restate what 
I commented on before. The way it is implemented now is quite bad. Every time 
you push a new commit, pretty much the whole image will be created from 
scratch. This is quite bad for someone who would like to pull the image 
regularly - because every time they pull it they will effectively pull the 
whole image as it will be single layer one. Plus you do not tap into benefit of 
docker downloading and decompressing the layers in parallel if you 
haveutli-layered image.
   
   Layering the image with separately installing apt-get dependencies and then 
installing airflow via pip on top of it and then possibly updating dependencies 
/ airflow (with possibility to rebuild starting from any layer if needed) could 
provide a much better experience with users only pulling incremental layers for 
future updates. I am happy to help with that if you think it is a good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to