zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] -
Configure FTP connection mode
URL: https://github.com/apache/airflow/pull/4535#discussion_r249269568
##########
File path: tests/contrib/hooks/test_ftp_hook.py
##########
@@ -115,7 +115,9 @@ def test_retrieve_file(self):
_buffer = six.StringIO('buffer')
with fh.FTPHook() as ftp_hook:
ftp_hook.retrieve_file(self.path, _buffer)
- self.conn_mock.retrbinary.assert_called_once_with('RETR path',
_buffer.write)
+ self.conn_mock.retrbinary.assert_called_once_with(
+ 'RETR path',
+ _buffer.write)
Review comment:
@OmerJog BTW, I don not think you should change this code to three lines,
just keep it like before
```suggestion
self.conn_mock.retrbinary.assert_called_once_with('RETR path',
_buffer.write)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
