zhongjiajie commented on a change in pull request #4535: [AIRFLOW-865] -
Configure FTP connection mode
URL: https://github.com/apache/airflow/pull/4535#discussion_r249271047
##########
File path: tests/contrib/hooks/test_ftp_hook.py
##########
@@ -115,7 +115,9 @@ def test_retrieve_file(self):
_buffer = six.StringIO('buffer')
with fh.FTPHook() as ftp_hook:
ftp_hook.retrieve_file(self.path, _buffer)
- self.conn_mock.retrbinary.assert_called_once_with('RETR path',
_buffer.write)
+ self.conn_mock.retrbinary.assert_called_once_with(
+ 'RETR path',
+ _buffer.write)
Review comment:
@OmerJog this repo flake8 length is 110, you can find in [this
line](https://github.com/apache/airflow/blob/31318ba8eb5b136277fc1672813cb57e68989abf/.flake8#L2),
and [source
code](https://github.com/apache/airflow/blob/31318ba8eb5b136277fc1672813cb57e68989abf/tests/contrib/hooks/test_ftp_hook.py#L118)
is only 86.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
