dima-asana commented on issue #4533: [WIP][AIRFLOW-3702] Reverse Backfilling
URL: https://github.com/apache/airflow/pull/4533#issuecomment-462011493
 
 
   Hi, unfortunately I didn't see this work until mostly duplicating it.
   
   https://github.com/apache/airflow/pull/4676 for my version, but obviously 
feel free to close that and accept this instead.
   
   Three bugs I see: 
   
   1. to_run in 
https://github.com/apache/airflow/pull/4533/files#diff-54a57ccc2c8e73d12c812798bf79ccb2R2410
 is a dict, so changing the order here won't do anything --- it'll get 
unordered again due to the list->dict conversion
   
   2. the run time is actually fairly arbitrary, and impossible to control due 
to parallel execution.  so you'd need to set the enqueued time in BackfillJob.
   
   3. right now your test checks execution date, which is neither the run time 
nor the enqueued time.  Somewhat confusingly Airflow uses "execution_date" to 
mean the date for which a given job is set to be scheduled rather than when it 
actually runs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to