dima-asana commented on issue #4533: [WIP][AIRFLOW-3702] Reverse Backfilling
URL: https://github.com/apache/airflow/pull/4533#issuecomment-462020314
 
 
   > If you don't mind, let's keep the discussion here to avoid duplicate pr. I 
will update the pr in these two days.
   
   Sure, sounds good.
   
   > I think we shouldn't allow reverse backfill if depend_past is true unless 
ignore_depend_on_past is set.
   
   The idea is fine by me (as opposed to just assuming that a user wouldn't do 
this).  Please note that the implementation currently in this PR is incorrect 
for that part, in addition to the user confusion Ash mentioned.  The 
ignore_first_depends_on_past checks explicitly only the start_date's 
dependency, so when it goes to check the most recent date it will still be 
blocked and never proceed (see 
https://github.com/apache/airflow/pull/4533/files#diff-54a57ccc2c8e73d12c812798bf79ccb2R2177).
  You'd probably want to instead add a lookup on the task instance and validate 
that it's not depends_on_past in the CLI command.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to