[
https://issues.apache.org/jira/browse/AIRFLOW-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765404#comment-16765404
]
ASF GitHub Bot commented on AIRFLOW-3869:
-----------------------------------------
ttanay commented on pull request #4692: [AIRFLOW-3869] Raise consistent
exception in AirflowConfigParser.getboolean
URL: https://github.com/apache/airflow/pull/4692
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3869
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
AirflowConfigParser.getboolean raises an AirflowConfigException when the
value of a configuration cannot be converted to boolean. But, getint and
getfloat raise a ValueError in the same case when the value cannot be casted to
the desired type.
They should raise the same exception - ValueError.
Also, added tests for getboolean, getint and getfloat.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
1. test_getboolean
2. test_getint
3. test_getfloat
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> raise consistent Exception in AirflowConfigParser.getboolean
> ------------------------------------------------------------
>
> Key: AIRFLOW-3869
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3869
> Project: Apache Airflow
> Issue Type: Improvement
> Components: configuration
> Affects Versions: 1.10.2
> Reporter: Tanay Tummalapalli
> Assignee: Tanay Tummalapalli
> Priority: Trivial
>
> The getboolean method of AirflowConfigParser class raises
> AirflowConfigException when the value of the configuration cannot be casted
> to bool. But, getint and getfloat raise ValueError in the same case.
> So, when getboolean cannot cast the value of the config to bool, it should
> raise ValueError.
> Also, add tests for the same.
> Reference:
> 1.
> [https://github.com/apache/airflow/blob/master/airflow/configuration.py#L272]
> 2. https://issues.apache.org/jira/browse/AIRFLOW-3742
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
