[
https://issues.apache.org/jira/browse/AIRFLOW-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766125#comment-16766125
]
ASF GitHub Bot commented on AIRFLOW-3869:
-----------------------------------------
Fokko commented on pull request #4692: [AIRFLOW-3869] Raise consistent
exception in AirflowConfigParser.getboolean
URL: https://github.com/apache/airflow/pull/4692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> raise consistent Exception in AirflowConfigParser.getboolean
> ------------------------------------------------------------
>
> Key: AIRFLOW-3869
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3869
> Project: Apache Airflow
> Issue Type: Improvement
> Components: configuration
> Affects Versions: 1.10.2
> Reporter: Tanay Tummalapalli
> Assignee: Tanay Tummalapalli
> Priority: Trivial
>
> The getboolean method of AirflowConfigParser class raises
> AirflowConfigException when the value of the configuration cannot be casted
> to bool. But, getint and getfloat raise ValueError in the same case.
> So, when getboolean cannot cast the value of the config to bool, it should
> raise ValueError.
> Also, add tests for the same.
> Reference:
> 1.
> [https://github.com/apache/airflow/blob/master/airflow/configuration.py#L272]
> 2. https://issues.apache.org/jira/browse/AIRFLOW-3742
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
