BasPH commented on a change in pull request #4715: [AIRFLOW-3894] unstructured 
connection to webhdfs
URL: https://github.com/apache/airflow/pull/4715#discussion_r257369754
 
 

 ##########
 File path: airflow/hooks/base_hook.py
 ##########
 @@ -88,6 +88,20 @@ def get_hook(cls, conn_id):
         connection = cls.get_connection(conn_id)
         return connection.get_hook()
 
+    @classmethod
 
 Review comment:
   Could you provide some detail about this method and the implementation? It's 
a bit confusing to me.
   
   I.e. Pydoc describing what input/output to expect and the behaviour of the 
method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to