BasPH commented on a change in pull request #4715: [AIRFLOW-3894] unstructured
connection to webhdfs
URL: https://github.com/apache/airflow/pull/4715#discussion_r257371112
##########
File path: airflow/hooks/webhdfs_hook.py
##########
@@ -67,9 +77,10 @@ def get_conn(self):
except HdfsError as e:
self.log.debug(
"Read operation on namenode {nn.host} "
- "failed with error: {e}".format(nn=nn, e=e)
+ "failed with error: {e}".format(**locals())
Review comment:
Don't log all local vars, but explicitly provide the vars that you want to
log. Generally speaking, explicitness is better because you know what to expect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
