Fokko commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges
to database
URL: https://github.com/apache/airflow/pull/4396#discussion_r257472310
##########
File path: airflow/jobs.py
##########
@@ -1869,7 +1869,7 @@ def __init__(
start_date=None,
end_date=None,
mark_success=False,
- donot_pickle=False,
+ donot_pickle=None,
Review comment:
Maybe consolidate this logic, since we're adding logic here that doesn't
really make sense.
This method is only invoked from here:
https://github.com/apache/airflow/blob/master/airflow/models/__init__.py#L3960
Here the `donot_pickle` is also loaded from the config:
https://github.com/apache/airflow/blob/master/airflow/models/__init__.py#L3933
Apart from that, it feels like we should set this on an Airflow level,
instead of a job level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
