Fokko commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges 
to database
URL: https://github.com/apache/airflow/pull/4396#discussion_r256349920
 
 

 ##########
 File path: airflow/jobs.py
 ##########
 @@ -1869,7 +1869,7 @@ def __init__(
             start_date=None,
             end_date=None,
             mark_success=False,
-            donot_pickle=False,
+            donot_pickle=None,
 
 Review comment:
   This change is a bit weird. The `BackfillJob(` is only instantiated here: 
https://github.com/apache/airflow/blob/master/airflow/models/__init__.py#L3954
   
   And this one gets it also from the config by default:
   
https://github.com/apache/airflow/blob/master/airflow/models/__init__.py#L3910
   
   So we're duplicating logic below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to