ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r259279651
##########
File path: airflow/models/__init__.py
##########
@@ -4872,11 +4872,12 @@ def get_previous_scheduled_dagrun(self, session=None):
).first()
@provide_session
- def update_state(self, session=None):
+ def update_state(self, session=None, finished_tasks=None):
"""
Determines the overall state of the DagRun based on the state
of its TaskInstances.
+ :param finished_tasks: The finished tasks collected ordered by dagrun
as a column (task_name, state)
Review comment:
The second thing this function does (line 4885) is get all the task
instances for the run, so I don't see the need to pass finished_tasks here.
Passing it on to the DepContext makes sense though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
