iwilltry42 commented on issue #4589: [AIRFLOW-3766] Add support for kubernetes 
annotations
URL: https://github.com/apache/airflow/pull/4589#issuecomment-468574296
 
 
   @feng-tao this is definitely a good thing, but it won't help in that case.
   Let me expand on this a little bit:
   I am using the 
[sidecar-injector](https://github.com/tumblr/k8s-sidecar-injector/), which 
requests an injection config using an annotation on pods like this: 
`"injector.tumblr.com/request": "sidecar-test"`.
   That way, I can inject e.g. a kerberos sidecar into each pod that's being 
created by the KubernetesExecutor.
   So I put this into the `airflow.cfg` under the `[kubernetes_annotations]` 
section: `injector.tumblr.com/request = sidecar-test`. This works just fine.
   Now if I want to define this in an environment variable like all the other 
config options, then it will fail, as 
`AIRFLOW__KUBERNETES_ANNOTATIONS__INJECTOR.TUMBLR.COM/REQUEST: sidecar-test` is 
not a valid environment variable (and also not a valid ConfigMap key) because 
of the `/` it contains.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to