iwilltry42 commented on issue #4589: [AIRFLOW-3766] Add support for kubernetes 
annotations
URL: https://github.com/apache/airflow/pull/4589#issuecomment-468610969
 
 
   @feng-tao so what about just having something like `annotation = 
annotation.replace("_._", "/")` to replace `_._` with a `/` before setting the 
annotation in the worker_config?
   That way the configuration env var would look like this `
   AIRFLOW__KUBERNETES_ANNOTATIONS__INJECTOR.TUMBLR.COM_._REQUEST` but end up 
in the pod annotation as `
   AIRFLOW__KUBERNETES_ANNOTATIONS__INJECTOR.TUMBLR.COM/REQUEST`.
   I'm pretty sure that `_._` is not a common pattern in annotation keys, but 
`/` is

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to