ashb commented on a change in pull request #4823: [AIRFLOW-3999] Remove all
inline style
URL: https://github.com/apache/airflow/pull/4823#discussion_r262068719
##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -28,13 +28,13 @@
<div>
<h3 class="pull-left">
{% if dag.parent_dag is defined and dag.parent_dag %}
- <span style='color:#AAA;'>SUBDAG: </span> <span> {{ dag.dag_id
}}</span>
+ <span class="text-gray">SUBDAG: </span> <span> {{ dag.dag_id }}</span>
{% else %}
<input id="pause_resume" dag_id="{{ dag.dag_id }}" type="checkbox" {{
"checked" if not dag.is_paused else "" }} data-toggle="toggle" data-size="mini"
method="post">
- <span style='color:#AAA;'>DAG: </span> <span> {{ dag.dag_id }}</span>
<small class="text-muted"> {{ dag.description }} </small>
+ <span class="text-gray">DAG: </span> <span> {{ dag.dag_id }}</span>
<small class="text-muted"> {{ dag.description }} </small>
{% endif %}
{% if root %}
- <span style='color:#AAA;'>ROOT: </span> <span> {{ root }}</span>
+ <span class="text-gray">ROOT: </span> <span> {{ root }}</span>
Review comment:
Can we come up with a different name for this class - I was taught that
having a property of the visual style in the class name is a code smell.
`class="dag-location"`? `class="dag-info-label"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
