ashb commented on a change in pull request #4823: [AIRFLOW-3999] Remove all
inline style
URL: https://github.com/apache/airflow/pull/4823#discussion_r262072510
##########
File path: airflow/www/templates/airflow/graph.html
##########
@@ -205,11 +212,11 @@
container: "body",
});
- d3.selectAll("div.legend_item.state")
+ d3.selectAll(".legend--state .legend__item")
Review comment:
I guess
```suggestion
d3.selectAll(".legend__state .legend__item")
```
as then `--` is separating the "type" from the value.
Another option is to use an additional attribute instead:
```
<div class="legend__item" data-legend-item="success">success</div>
```
and then CSS of
```
.legend__item[data-legend-item="#{$name}"] {
}
```
(Check my CSS syntax there. I did this one from memory)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
