ashb commented on a change in pull request #4685: [AIRFLOW-3862] Check types 
with mypy.
URL: https://github.com/apache/airflow/pull/4685#discussion_r262954679
 
 

 ##########
 File path: airflow/contrib/operators/adls_list_operator.py
 ##########
 @@ -46,7 +48,7 @@ class AzureDataLakeStorageListOperator(BaseOperator):
                 azure_data_lake_conn_id='azure_data_lake_default'
             )
     """
-    template_fields = ('path',)
+    template_fields = ('path',)  # type: Sequence[str]
 
 Review comment:
   Whaaaaat. That strikes me as a bug in mypy - since there is no type 
annotation on B.a it should keep the one from A. Oh well.
   
   Thanks for the explanation.
   
   Still, let's change for `Iterable[Str]` where we do have to have an  
annotation (over `Sequence`) - I reported/asked about this in 
https://github.com/python/mypy/issues/6511

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to