ashb commented on a change in pull request #4685: [AIRFLOW-3862] Check types
with mypy.
URL: https://github.com/apache/airflow/pull/4685#discussion_r263369460
##########
File path: airflow/models/__init__.py
##########
@@ -1021,9 +1027,8 @@ def are_dependents_done(self, session=None):
count = ti[0][0]
return count == len(task.downstream_task_ids)
- @property
@provide_session
- def previous_ti(self, session=None):
+ def get_previous_ti(self, session=None):
Review comment:
Actually, since the property is the "preferred" way could we name the method
`_get_previous_ti` please? (otherwise this might show up in generated API docs
and cause confusion as which one is the "recommended" one to call)
Or do you think it's okay to have both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
