XD-DENG commented on issue #4878: [AIRFLOW-4046] Added validations for poke_interval & timeout for Airflow Sensor URL: https://github.com/apache/airflow/pull/4878#issuecomment-470926394 Hi @kani5hk if you mean to do validation/checking in __init__ to "fail as early as possibly if any", I think it may make sense to do it. Regarding type check: I think you should not check for 'str'. Instead, any type other than 'int' should fail. So you may want to have something like `if not isinstance(x, int)` rathar than `if isinstance(x, str)`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
