XD-DENG commented on issue #4878: [AIRFLOW-4046] Added validations for poke_interval & timeout for Airflow Sensor URL: https://github.com/apache/airflow/pull/4878#issuecomment-471305903 @kani5hk If you do the inputs validation as a separate method, I think it's still better to have it as a non-public method by adding underscore prefix. Understand you had issue with method name `_validate_inputs`. I'm not sure if it's because of name conflicting or the nature as a non-public method? Good to be merged after this minor point is addressed. Thanks
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
