kaxil commented on a change in pull request #10784:
URL: https://github.com/apache/airflow/pull/10784#discussion_r490614575
##########
File path: Dockerfile.ci
##########
@@ -256,7 +256,7 @@ ENV
UPGRADE_TO_LATEST_CONSTRAINTS=${UPGRADE_TO_LATEST_CONSTRAINTS}
# But in cron job we will install latest versions matching setup.py to see if
there is no breaking change
# and push the constraints if everything is successful
RUN \
- if [[ "${UPGRADE_TO_LATEST_CONSTRAINTS}" == "true" ]]; then \
+ if [[ "${UPGRADE_TO_LATEST_CONSTRAINTS}" != "false" ]]; then \
Review comment:
That was my impression and understanding too but when it failed
`azure-identity` few days back and today again when I pushed that commit to
v1-10-test the commit failed with `module not found`.
(btw thanks again for the detailed explanation)
##########
File path: Dockerfile.ci
##########
@@ -256,7 +256,7 @@ ENV
UPGRADE_TO_LATEST_CONSTRAINTS=${UPGRADE_TO_LATEST_CONSTRAINTS}
# But in cron job we will install latest versions matching setup.py to see if
there is no breaking change
# and push the constraints if everything is successful
RUN \
- if [[ "${UPGRADE_TO_LATEST_CONSTRAINTS}" == "true" ]]; then \
+ if [[ "${UPGRADE_TO_LATEST_CONSTRAINTS}" != "false" ]]; then \
Review comment:
That was my impression and understanding too but when it failed
`azure-identity` few days back and today again when I pushed that commit to
v1-10-test the commit failed with `module not found`.
(btw thanks for the detailed explanation)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
