potiuk commented on a change in pull request #10784:
URL: https://github.com/apache/airflow/pull/10784#discussion_r488685014
##########
File path: Dockerfile.ci
##########
@@ -256,7 +256,7 @@ ENV
UPGRADE_TO_LATEST_CONSTRAINTS=${UPGRADE_TO_LATEST_CONSTRAINTS}
# But in cron job we will install latest versions matching setup.py to see if
there is no breaking change
# and push the constraints if everything is successful
RUN \
- if [[ "${UPGRADE_TO_LATEST_CONSTRAINTS}" == "true" ]]; then \
+ if [[ "${UPGRADE_TO_LATEST_CONSTRAINTS}" != "false" ]]; then \
Review comment:
And in case there is a problem with any dependencies we will see merge
builds failing, but it will not impact the PRs. This so far happened only when
setup.py changed, but I believe smaller incremental upgrades after every merge
make much more sense as we will precisely see what caused the problems. I also
plan to show a "constraint diff" in such build shortly soo that we immediately
see which changed requirements caused failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
