pingzh commented on a change in pull request #10996:
URL: https://github.com/apache/airflow/pull/10996#discussion_r490671315
##########
File path: airflow/cli/commands/dag_command.py
##########
@@ -400,7 +400,7 @@ def generate_pod_yaml(args):
pod = PodGenerator.construct_pod(
dag_id=args.dag_id,
task_id=ti.task_id,
- pod_id=AirflowKubernetesScheduler._create_pod_id( # pylint:
disable=W0212
+ pod_id=_create_pod_id( # pylint: disable=W0212
Review comment:
Given that we are exposing the `_create_pod_id`, we can rename it as
`create_pod_id`?
##########
File path: airflow/executors/base_executor.py
##########
@@ -63,7 +63,7 @@ def __init__(self, parallelism: int = PARALLELISM):
self.running: Set[TaskInstanceKey] = set()
self.event_buffer: Dict[TaskInstanceKey, EventBufferValueType] = {}
- def start(self): # pragma: no cover
+ def start(self, job_id=None): # pragma: no cover
Review comment:
given that the `start` interface is changed, we also need to update
other executors, like
https://github.com/apache/airflow/blob/master/airflow/executors/celery_kubernetes_executor.py#L60-L63
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
