colin-streicher commented on issue #4574: [AIRFLOW-3751] Ignore malformed ldap 
schema option
URL: https://github.com/apache/airflow/pull/4574#issuecomment-471131621
 
 
   @seelmann I completely missed the notification for this comment, and it even 
though it is already merged, it is worth responding to I think. 
   
   My initial thought was to use the set_info setting, this would have the 
added benefit of being able to set the level of requested information from the 
server to several different levels. However, I decided against this because the 
upstream ldap library was using this set_info setting as default. Since I do 
not understand why this is the case, I decided that setting the malformed 
schema option was safer in that the name of the option implies that schema 
checking is being turned off. 
   
   Regardless, the result of both end up being the same, so I would have been 
ok with either. I had few more changes that allowed more options, but with the 
move to FAB, it doesn't seem like they would be used. 
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to