feluelle commented on pull request #9246:
URL: https://github.com/apache/airflow/pull/9246#issuecomment-697180207


   Javier I also removed the following from the description:
   
   > - Modified a part in the copy statement, that will makes prior workflows 
incompatible. Not sure if I have to propose a discussion about this point 
somewhere else (If so, I will delete this part from this PR) or just create a 
note in UPDATING.md. The prior code was:
   > ```
   > COPY {self.schema}.{self.table}
   >             FROM 's3://{self.s3_bucket}/{self.s3_key}/{self.table}'
   >             with credentials
   >             
'aws_access_key_id={credentials.access_key};aws_secret_access_key={credentials.secret_key}'
   >             {copy_options};
   > ```
   > And the new is:
   > ```
   > COPY {self.schema}.{self.table}
   >             FROM 's3://{self.s3_bucket}/{self.s3_key}'
   >             with credentials
   >             
'aws_access_key_id={credentials.access_key};aws_secret_access_key={credentials.secret_key}'
   >             {copy_options};
   > ```
   > So we don't have to have the table as the file name. I have read here and 
somewhere else complains about the existence of the table at the end of the 
from. 
   
   ..as this isn't in your changes / PR ?!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to