kaxil commented on a change in pull request #10996:
URL: https://github.com/apache/airflow/pull/10996#discussion_r493788311
##########
File path: airflow/executors/base_executor.py
##########
@@ -64,6 +66,22 @@ def __init__(self, parallelism: int = PARALLELISM):
self.running: Set[TaskInstanceKey] = set()
self.event_buffer: Dict[TaskInstanceKey, EventBufferValueType] = {}
+ @property
+ def job_id(self):
Review comment:
Can we add type hints please
##########
File path: airflow/executors/base_executor.py
##########
@@ -64,6 +66,22 @@ def __init__(self, parallelism: int = PARALLELISM):
self.running: Set[TaskInstanceKey] = set()
self.event_buffer: Dict[TaskInstanceKey, EventBufferValueType] = {}
+ @property
+ def job_id(self):
+ """
+ Get job_id for SchedulerJob
+ @return:
+ """
+ return self._job_id
+
+ @job_id.setter
+ def job_id(self, value):
Review comment:
Can we add type hints please
##########
File path: airflow/executors/base_executor.py
##########
@@ -64,6 +66,22 @@ def __init__(self, parallelism: int = PARALLELISM):
self.running: Set[TaskInstanceKey] = set()
self.event_buffer: Dict[TaskInstanceKey, EventBufferValueType] = {}
+ @property
+ def job_id(self):
+ """
+ Get job_id for SchedulerJob
+ @return:
Review comment:
```suggestion
```
##########
File path: airflow/executors/base_executor.py
##########
@@ -64,6 +66,22 @@ def __init__(self, parallelism: int = PARALLELISM):
self.running: Set[TaskInstanceKey] = set()
self.event_buffer: Dict[TaskInstanceKey, EventBufferValueType] = {}
+ @property
+ def job_id(self):
+ """
+ Get job_id for SchedulerJob
+ @return:
+ """
+ return self._job_id
+
+ @job_id.setter
+ def job_id(self, value):
+ """
+ Allows SchedulerJob to set job_id variable
+ @return:
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
