kaxil commented on a change in pull request #10996:
URL: https://github.com/apache/airflow/pull/10996#discussion_r493792777
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -470,6 +475,37 @@ def terminate(self) -> None:
self._manager.shutdown()
+def _strip_unsafe_kubernetes_special_chars(string: str) -> str:
+ """
+ Kubernetes only supports lowercase alphanumeric characters and "-" and "."
in
+ the pod name
+ However, there are special rules about how "-" and "." can be used so let's
+ only keep
+ alphanumeric chars see here for detail:
+ https://kubernetes.io/docs/concepts/overview/working-with-objects/names/
Review comment:
```suggestion
Kubernetes only supports lowercase alphanumeric characters, "-" and "."
in
the pod name.
However, there are special rules about how "-" and "." can be used so
let's
only keep
alphanumeric chars see here for detail:
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
