kaxil commented on a change in pull request #11135:
URL: https://github.com/apache/airflow/pull/11135#discussion_r494553252
##########
File path: airflow/providers/salesforce/hooks/salesforce.py
##########
@@ -75,7 +76,7 @@ def get_conn(self):
)
return self.conn
- def make_query(self, query, include_deleted=False, query_params=None):
+ def make_query(self, query: str, include_deleted: bool = False,
query_params: Optional[Dict] = None) -> Dict:
Review comment:
```suggestion
def make_query(self, query: str, include_deleted: bool = False,
query_params: Optional[dict] = None) -> dict:
```
We could just keep it as `dict` since that is same as Dict[Any, Any] (and
same as Dict)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
