mlgruby commented on a change in pull request #11135:
URL: https://github.com/apache/airflow/pull/11135#discussion_r494564446
##########
File path: airflow/providers/salesforce/hooks/salesforce.py
##########
@@ -75,7 +76,7 @@ def get_conn(self):
)
return self.conn
- def make_query(self, query, include_deleted=False, query_params=None):
+ def make_query(self, query: str, include_deleted: bool = False,
query_params: Optional[Dict] = None) -> Dict:
Review comment:
Yup, that will keep things simple!
##########
File path: airflow/providers/salesforce/operators/tableau_refresh_workbook.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-from typing import Optional
+from typing import Optional, Any, Dict
Review comment:
forgot to optimize the import :D
##########
File path: airflow/providers/salesforce/operators/tableau_refresh_workbook.py
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-from typing import Optional
+from typing import Optional, Any, Dict
Review comment:
forgot to optimize imports :D
##########
File path: airflow/providers/salesforce/hooks/salesforce.py
##########
@@ -270,7 +276,12 @@ def write_object_to_file(
return df
- def object_to_df(self, query_results, coerce_to_timestamp=False,
record_time_added=False):
+ def object_to_df(
+ self,
+ query_results: List[Dict],
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
