mik-laj commented on a change in pull request #11197:
URL: https://github.com/apache/airflow/pull/11197#discussion_r498540016



##########
File path: docs/howto/connection/oracle.rst
##########
@@ -85,3 +85,36 @@ Extra (optional)
     .. code-block:: bash
 
         export 
AIRFLOW_CONN_ORACLE_DEFAULT='oracle://oracle_user:[email protected]:1521?encoding=UTF-8&nencoding=UTF-8&threaded=False&events=False&mode=sysdba&purity=new'
+
+
+Tips and Tricks for Oracle Shops
+================================
+
+Oracle users an SID to identify a unique database instance. Oracle also has an 
unusual definition of schema and user, wherein a schema set of objects owned by 
a user. Therefore, creating a connection through the Airflow web GUI can be 
confusing.
+
+To create a connection: 
+
+- Go to Admin => Connections => Create
+
+- Name your connection
+
+- Select connection type: Oracle
+
+- Enter your hostname in the following format: NameOrIP:PORT#/SID Example(s): 
10.0.0.111:1521/orcl or weshouldhaveusedpostgres.ourdomain.com:1521/dev

Review comment:
       I wonder if it makes sense to add these sections. This greatly 
duplicates the description in the section above or [the page one level 
higher](https://airflow.readthedocs.io/en/latest/howto/connection/index.html). 
What do you think? Is this information duplicated or maybe I missed something?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to