potiuk commented on a change in pull request #10956:
URL: https://github.com/apache/airflow/pull/10956#discussion_r499545612
##########
File path: airflow/models/dagrun.py
##########
@@ -94,8 +103,14 @@ def __init__(
self.conf = conf or {}
self.state = state
self.run_type = run_type
+ self.dag_hash = dag_hash
+ self.callback: Optional[callback_requests.DagCallbackRequest] = None
Review comment:
Can we return the callback as a result of the update_state method rather
than setting the property on the DB object? It sounds weird to add non-DB
property in the DB model.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
