potiuk commented on a change in pull request #10956:
URL: https://github.com/apache/airflow/pull/10956#discussion_r499646376
##########
File path: airflow/models/dagrun.py
##########
@@ -94,8 +103,14 @@ def __init__(
self.conf = conf or {}
self.state = state
self.run_type = run_type
+ self.dag_hash = dag_hash
+ self.callback: Optional[callback_requests.DagCallbackRequest] = None
Review comment:
I think that's the easiest way - if we add type checking it's not even
bad (and actually maybe we can also find a better name for the update_state
method which we wrote about elsewhere. The update_state is not a really good
name now as this method does more than that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
